api: proxy: custom: Implement APIs for custom Go plugins #10299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support OTel extensions * Remove needless Golang related files from the original sketch commit Signed-off-by: Rob Skillington <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-go-custom-extension
branch
from
de56254 to
6d6dfcb
Compare
edsiper
requested changes
May 7, 2025
cosmo0920
force-pushed
the
cosmo0920-go-custom-extension
branch
from
d201c70 to
e152ad2
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-go-custom-extension
branch
from
e152ad2 to
8d4db49
Compare
cosmo0920
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-go-custom-extension
branch
from
6d54d88 to
2e9c39f
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-go-custom-extension
branch
from
2e9c39f to
a054862
Compare
edsiper
requested changes
May 26, 2025
| plugin->context = ((struct flb_custom_instance *)proxy->instance)->context; | ||
|
|
||
| ret = plugin->cb_init(plugin); | ||
| if (ret <= 0) { |
There was a problem hiding this comment.
why a 0 return value is considered an error ?
There was a problem hiding this comment.
This is because FLB_ERROR is defined as 0 in flb_macros.h here: https://github.com/fluent/fluent-bit/blob/master/include/fluent-bit/flb_macros.h#L29 which means we need to handle 0 as error, too.
Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some motivations to support custom plugin mechanism in Fluent Bit, we need to implement custom plugins which are built on top of Golang infrastructures.
This PR makes to be able to provide and support Golang custom plugins.
This PR is based on #9470 but adding modifications with working on calyptia-plugin module which is maintained here:
chronosphereio/calyptia-plugin#101
Plus, we need to implement custom plugin mechanism calyptia-plugin modue.
So, I also implemented custom Golang mechanism in chronosphereio/calyptia-plugin#101.
Note that we might have to maintain ABI for plugin API like logging and obtaining cmetrics instances.
I just adding APIs for custom plugins afterwards of input or output API definitions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.